NativeUtil.h:
88: How about puts(s) or printf("%s", s) (in case s includes "%")?
NativeUtil.c:
514-516: not necessary?
539-543: Why not TRACEn here?
639-659: It looks like if cbytes == NULL then the function returns NULL with no
exception throwing and this would break something in GSSLibStub.c. But actually
cbytes will never be NULL there, right? How about remove the cbytes == NULL
check at all?
644: I have no idea why cbytes->length != 0 is checked. Why cannot it be an
empty string?
GSSLibStub.c:
92: This need not be a jboolean, just use an int.
536: I guess getJavaString on 529 already released outNameBuf?
1103: This is not only "cleanup", it is "error".
1105: Not safe to releaseName/releaseCred here?
Thanks
Max
On Mar 15, 2014, at 6:11, Valerie (Yu-Ching) Peng <[email protected]>
wrote:
> Max,
>
> Can you please help reviewing the fix for 8031003: [Parfait] warnings from
> jdk/src/share/native/sun/security/jgss/wrapper: JNI exception pending?
>
> I ended up re-factoring the code to clean things up. So, the changes are
> somewhat extensive. I have also replaced the debug callbacks with native
> printf calls.
>
> The webrev is:
> http://cr.openjdk.java.net/~valeriep/8031003/webrev.00/
>
> Thanks,
> Valerie
