On 05/07/2014 03:12 PM, Jamil Nimeh wrote:
Please review the webrev for JDK-6996377 when you get a chance.
http://cr.openjdk.java.net/~ascarpino/6996377/webrev.01/
- PKIXValidator[130]: you can use the diamond operator to make the code
more concise:
new HashMap<>();
- shell script tests are somewhat discouraged going forward, since they
are harder to debug and can have various cross-platform issues, etc. Do
you think you could try to just create a Java test? One option is to
hard-code the certs (base64-encoded) inside the Java source code and use
CertificateFactory to instantiate them. If you do that, you should
include the keytool commands that you used to create the certs in
comments so that they can be re-created later on if necessary.
--Sean
