Looks fine to me. Xuelei
> On Jun 12, 2014, at 10:57 PM, Wang Weijun <weijun.w...@oracle.com> wrote: > > Oh, I made the mistake again, on Solaris "export ENV=var" is not always > correct. > > Please review the code change at > > http://cr.openjdk.java.net/~weijun/8046702/webrev.00/ > > The fix is as simple as > > -----START----- > diff --git a/test/sun/security/tools/keytool/default_options.sh > b/test/sun/security/tools/keytool/default_options.sh > --- a/test/sun/security/tools/keytool/default_options.sh > +++ b/test/sun/security/tools/keytool/default_options.sh > @@ -38,7 +38,8 @@ > > rm $KS 2> /dev/null > > -export PASS=changeit > +PASS=changeit > +export PASS > > # keytool > -----END----- > > I was using "-storepass changeit" but at the final second I changed it to > > export PASS=changeit > keytool -storepass:env PASS > > and thought it looks more secure. I should have run it on all platforms again. > > Thanks > Max >
