On Jul 8, 2014, at 2:00, Sean Mullan <sean.mul...@oracle.com> wrote:
> Looks good, just one comment in GssKrb5Base - I would change > getNegotiatedProperty to call the superclass method first, and then if that > returns null, check for the gss inquiretype properties. This way you don't > check for IllegalStateExc twice, and it seems cleaner to me. My understanding is that if getNegotiatedProperty() methods of both parent class and child class return non-null, then the value from the child class should shadow the one from the parent. > > Also, please add a release notes label so that this is documented in the > release notes, and open a separate docs bug to add a section to the SASL > Reference Guide to more fully describe these new properties and how to use > them. Sure. Thanks Max >> http://cr.openjdk.java.net/~weijun/8044085/webrev.00 >>
