On Jul 21, 2014, at 20:24, Sean Mullan <[email protected]> wrote:
> On 07/21/2014 08:19 AM, Wang Weijun wrote: >> >> On Jul 21, 2014, at 20:11, Sean Mullan <[email protected]> wrote: >> >>> This looks fine to me, but I was wondering why you needed to do this - are >>> there requirements to run some regression tests with just the JRE instead >>> of the full JDK? >> >> The embedded team has the requirement. They've already spotted several tests >> in jdk8 having the problem. These 2 tests are new in jdk9 and I think they >> will run into it one day. > > How are they doing this? How do they know to not run the jarsigner tests? Are > they identifying and then creating separate jtreg groups for tests that run > with the JRE only? It seems like there should be a new jtreg tag or something > like that which specifies if a test can run with the JRE only; otherwise this > seems like it will be hard to maintain over time. test/TEST.groups has a group named needs_jdk which includes sun/security/tools/jarsigner. These test are not run when testing jre. In fact, it should be called test_jdk because as long as a test is not testing jdk itself and jdk is only used in preparing testing materials, we can use -compilejdk to provide a good-old-jdk to prepare them. In this sense, -compilejdk should also probably be renamed to -goodoldjdk (CCing Jon). :-) --Max > > --Sean
