Rob,
Looks ok to me too. There are probably other places with RTE's we could
fix, but this will solve the immediate problem.
Two comments to consider:
1. Use a Multi-catch exception. JDK7+.
2. DHCrypt throws IOException. ECDHCrypt throws SSLException (which is
an IOException). Since DHCrypt/ECDHCrypt are essentially the same kind
of class, maybe update DHCrypt to throw the same?
Brad
On 7/25/2014 5:52 PM, Xuelei Fan wrote:
Looks fine to me.
Thanks,
Xuelei
On 7/22/2014 9:37 PM, Rob McKenna wrote:
Hi folks,
A simple change to use SSLHandshakeException instead of RuntimeException
in getAgreedSecret in DHCrypt and ECDHCrypt. This will prevent these
RuntimeExceptions from propagating to the application and allow
application programmers to handle them as SSLHandshakeExceptions.
http://cr.openjdk.java.net/~robm/8042982/webrev.01/
-Rob
