The updated webrev looks fine. However I do have a general comment.
There are other methods that require a permission to be granted in order
to invoke them.
It may make more sense to create a very general test that can be used to
test all of these methods, or perhaps subclassed or overridden depending
on what module the methods are in. I know you have created other common
testlibrary functions, so maybe it can be a part of that library. Can
you think about that a bit and let me know if it is practical?
--Sean
On 08/19/2014 04:59 AM, FELIX YANG wrote:
Fixed, new Webrev:
http://cr.openjdk.java.net/~weijun/8048052/webrev.00/
Thanks!
-Felix
On 8/18/2014 10:17 PM, Wang Weijun wrote:
We don't write "@bug JDK-8048052". Should be "@bug 8048052".
--Max
On Jul 28, 2014, at 17:04, FELIX YANG <felix.y...@oracle.com> wrote:
Please review a new test to "setFactory" permission. It is to address
that "setFactory" permission is required or not as expected in a
series of classes/methods under java.net.
JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8048052
Webrev: http://cr.openjdk.java.net/~rhalade/8048052/webrev.00/
Thanks
-Felix
