1. Yes, reqMethod can be brought into the for-loop. It could even be
local to the try block I think.
2. Good catch on the spec. I'll fix that, too.
Thanks,
--Jamil
On 08/20/2014 06:51 PM, Wang Weijun wrote:
Hi Jamil
Code change looks fine.
Two small nits:
1. Why is "Method reqMethod;" method level? Can it be a local variable inside
the loop?
2. The spec of new method
893 * ... This method will first
894 * try to match the method by both name and parameter list.
We now find interface method at first.
Thanks
Max
On Aug 21, 2014, at 5:38, Jamil Nimeh <[email protected]> wrote:
Hello everyone,
This is an updated review that addresses comments from the original webrev.
http://cr.openjdk.java.net/~ascarpino/6562449/webrev.02
Thank you,
--Jamil
On 08/11/2014 02:56 PM, Jamil Nimeh wrote:
Hello all,
This webrev covers a fix to LoginContext so it no longer selects the wrong
method when a LoginModule method (login, logout, commit, etc.) has been
overloaded.
Bug: https://bugs.openjdk.java.net/browse/JDK-6562449
Webrev: http://cr.openjdk.java.net/~ascarpino/6562449/webrev.01
Thank you,
--Jamil
