I found an error:
diff --git
a/src/jdk.dev/share/classes/com/sun/tools/hat/internal/util/Misc.java
b/src/jdk.dev/share/classes/com/sun/tools/hat/internal/util/Misc.java
--- a/src/jdk.dev/share/classes/com/sun/tools/hat/internal/util/Misc.java
+++ b/src/jdk.dev/share/classes/com/sun/tools/hat/internal/util/Misc.java
@@ -97,11 +97,11 @@
} else if (ch == '&') {
sb.append("&");
} else if (ch < ' ') {
- sb.append("&#" + Integer.toString(ch) + ";");
+ sb.append("&#").append((int)ch).append(';');
} else {
int c = (ch & 0xFFFF);
if (c > 127) {
- sb.append("&#" + Integer.toString(c) + ";");
+ sb.append("&#").append((int)c).append(';');
} else {
sb.append(ch);
}
In the 2nd change, it should be "append(c)" instead of "append((int)c)". Here c
is already an integer and this redundant cast will be treated as an error when
-Werror specified.
--Max
On Aug 27, 2014, at 10:07, Wang Weijun <[email protected]> wrote:
> Webrev updated again, this time include more changes.
>
> http://cr.openjdk.java.net/~weijun/8055723/client/webrev.02/
> http://cr.openjdk.java.net/~weijun/8055723/core/webrev.02/
>
> The change to a demo file is removed because that file itself is already
> removed.
>
> *Otávio*: I believe Andrej's following suggestion is worth looking at.
>
> Thanks
> Max
>
> On Aug 26, 2014, at 19:12, Andrej Golovnin <[email protected]> wrote:
>
>>
>> src/java.base/share/classes/sun/security/x509/X509CRLEntryImpl.java:
>> 316 sb.append("Extension unknown: " + "DER
>> encoded OCTET string =\n")
>>
>> should be changed to:
>> 316 sb.append("Extension unknown: DER encoded
>> OCTET string =\n")
>>
>> same problems are in
>> src/java.base/share/classes/sun/security/x509/X509CRLImpl.java in the line
>> 576
>> src/java.base/share/classes/sun/security/x509/X509CertInfo.java in the line
>> 332
>>
>> Best regards,
>> Andrej Golovnin
>
