Hi Vincent,
Would you be able push this change for my be half.
Full comments:
8048362 : Tests for doPrivileged with accomplice
Reviewed-by: Vincent Ryan
Contributed-by: Raghu Nair <raghu.k.n...@oracle.com>
webrev: http://cr.openjdk.java.net/~tyan/raghu/8048362/webrev.04/
Thanks,
Raghu
On 8/20/2014 10:40 PM, raghu k.nair wrote:
Hello,
Please review the updated webrev :
http://cr.openjdk.java.net/~tyan/raghu/8048362/webrev.04/
<http://cr.openjdk.java.net/%7Etyan/raghu/8048362/webrev.04/>
I have updated the path of JavaToolUtils in DoPrivAccompliceTest.java.
Thanks,
Raghu
On 8/12/2014 11:06 PM, raghu k.nair wrote:
Hello ,
The latest webrev is available at
http://cr.openjdk.java.net/~rhalade/8048362/webrev.03/
<http://cr.openjdk.java.net/%7Erhalade/8048362/webrev.03/> The
changes include review comments from Vinnie .
Thanks,
Raghu
On 8/8/2014 7:21 PM, Vincent Ryan wrote:
Code looks fine.
I noticed a few typos: DoPrivTest.java l.26 and
DoPrivAccompliceTest.java l.34-38
On 4 Aug 2014, at 08:11, raghu k.nair <raghu.k.n...@oracle.com> wrote:
Hello ,
Please review the updated tests for doPrivilaged with accomplice.
Updated the test to use @compile tag rather than compiling using API.
Bug -https://bugs.openjdk.java.net/browse/JDK-8048362
webrev - http://cr.openjdk.java.net/~rhalade/8048362/webrev.01/
<http://cr.openjdk.java.net/%7Erhalade/8048362/webrev.01/>
Thanks,
Raghu