Updated webrev looks good.
--Sean
On 11/07/2014 12:08 PM, Anthony Scarpino wrote:
On 11/07/2014 04:44 AM, Sean Mullan wrote:
On 11/06/2014 07:06 PM, Anthony Scarpino wrote:
It's completely dependent on Xcheck:jni. I figured that was an option
part of the testing process. Not something that one put into a test. Is
that wrong?
You could put it as an option in the @run tag, ex:
@run main/othervm -Xcheck:jni ...
There are a handful of tests that do that. Is there an existing test you
could add that run tag to to reproduce the issue?
--Sean
I made a similar test to the one that failed in the JCK. Finding an
example wasn't hard.
I updated the webrev in place, so hit refresh on the link again and
you'll see the test
Tony
Tony
On 11/06/2014 02:37 PM, Sean Mullan wrote:
It looks ok to me although I think Valerie should also review it. Is it
possible to add a simple regression test for this and not be dependent
on the JCK tests?
--Sean
On 11/06/2014 05:14 PM, Anthony Scarpino wrote:
Hi,
I need a review of this change to the pkcs11 wrapper code. The
changes
allow encryption to work properly when -Xcheck:jni is called. A
recent
change to -Xcheck:jni caused the failures to occur.
http://cr.openjdk.java.net/~ascarpino/8063700/webrev/
thanks
Tony
