On 11/24/2014 03:59 AM, Wang Weijun wrote:
On Nov 19, 2014, at 22:10, Sean Mullan <sean.mul...@oracle.com> wrote:
On 11/18/2014 02:47 AM, Wang Weijun wrote:
Re-request for code review at
http://cr.openjdk.java.net/~weijun/8061253/webrev.01/
* Principal:
This should also be included in the @implSpec, is it? You might need another implSpec
tag before this, or remove the <p> as it isn't really necessary.
Looks like one is enough.
Is this OK?
Yes.
* General
Sometimes you say "the Foo" and other times you say "this Foo". I think you should try to
be consistent. I prefer "this Foo".
OK, I'll go through it.
I've s/the/this/ed in all hashCode() and toString().
If you don't have other comment, I'll push it.
Ok.
--Sean
