Hi Valerie,
I have updated the webrev, please take a look.
http://cr.openjdk.java.net/~asmotrak/8048603/webrev.02/
Artem
On 12/16/2014 01:38 AM, Valerie Peng wrote:
Artem,
Here are my comments:
1) Three tests under com/sun/crypto/provider directory do not specify
a provider when calling Mac.getInstance(). Since they are under the
regression tests directory for SunJCE, perhaps we should specify
SunJCE provider to be used.
2) 'ALGORITHMS' seems redundant for
sun/security/pkcs11/Mac/MacSameTest.java
Thanks,
Valerie
On 12/11/2014 2:17 AM, Artem Smotrakov wrote:
I have addressed a couple of comments from Valerie:
- updated tests in test/com/sun/crypto/provider/Mac not to test
SunPKCS11 provider
- added the following tests for PKCS11 providers
test/sun/security/pkcs11/Mac/MacKAT.java
test/sun/security/pkcs11/Mac/MacSameTest.java
- removed a check that CloneNotSupportedException is thrown on Solaris
Please take a look.
http://cr.openjdk.java.net/~asmotrak/8048603/webrev.01/
Artem
On 11/07/2014 01:07 PM, Artem Smotrakov wrote:
Please review a couple of new test cases for MAC algorithms.
https://bugs.openjdk.java.net/browse/JDK-8048603
http://cr.openjdk.java.net/~asmotrak/8048603/webrev.00/
Artem
