On 3/14/2015 6:54 PM, Jamil Nimeh wrote: > Or we could just take care of it now, since I'm already making enums out > of things. > > http://cr.openjdk.java.net/~jnimeh/reviews/6996366/webrev.02/ > Looks fine to me.
> I don't see any differences in jtreg results across the 211 ssl tests I > ran so that seems like a good sign. I've got a jprt run going now to > see if anything happens there. Let me know what you think. > It's OK as the JPRT jobs passed. Please add a "noreg-cleanup" tag as this is a refactoring of existing code and need no additional test. Thanks, Xuelei > --Jamil > > On 03/14/2015 01:08 AM, Xuelei Fan wrote: >> Looks fine to me. >> >> Do you want to consider a similar conversion on BulkCipher? Maybe in a >> new bug. >> >> Thanks, >> Xuelei >> >> On 3/12/2015 7:55 AM, Jamil Nimeh wrote: >>> Hello all, >>> >>> This bug moves the internal MacAlg concrete class to an enum, and alters >>> the CipherSuite constructor to no longer use String parsing on the >>> cipher suite name to determine the MacAlg. Instead, the constructor now >>> requires the caller to pass in a MacAlg, similar to how it already takes >>> a KeyExchange and BulkCipher. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-6996366 >>> Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/6996366/webrev.01/ >>> >>> Thanks, >>> --Jamil >
