Re: RFR 8056174: New APIs for jar signing

[Weijun Wang]

Hi All

Webrev updated at http://cr.openjdk.java.net/~weijun/8056174/webrev.01/.
Major changes:

1. JarSignerException is now a RuntimeException, no more ErrorCode

2. Action.java and Builder.java moved into sun.security.tools.jarsigner. 
Hopefully the jarsigner tool can use them.

The code changes in the root repo remain unchanged. The 
unshuffle_list.txt also remains. We are considering backporting the 
enhancement to jdk8u to ease the transition from calling internal 
jarsigner class to this new API.

Thanks to Mandy and Sean for the code review.

--Max

On 3/24/2015 5:47 PM, Wang Weijun wrote:
Hi All

Please review the code change at

    http://cr.openjdk.java.net/~weijun/8056174/webrev.00/

It provides a new jdk.Exported API JarSigner to perform jar signing. The class 
contains popular functions of the jarsigner tool. The jarsigner tool is 
unchanged and currently independent of the new class.

The root repo also needs a little change:

diff --git a/common/bin/unshuffle_list.txt b/common/bin/unshuffle_list.txt
--- a/common/bin/unshuffle_list.txt
+++ b/common/bin/unshuffle_list.txt
@@ -1305,6 +1304,7 @@
  jdk/src/jdk.httpserver/share/classes/com/sun/net/httpserver : 
jdk/src/share/classes/com/sun/net/httpserver
  jdk/src/jdk.httpserver/share/classes/sun/net/httpserver : 
jdk/src/share/classes/sun/net/httpserver
  jdk/src/jdk.jartool/share/classes/com/sun/jarsigner : 
jdk/src/share/classes/com/sun/jarsigner
+jdk/src/jdk.jartool/share/classes/jdk/security/jarsigner : 
jdk/src/share/classes/jdk/security/jarsigner
  jdk/src/jdk.jartool/share/classes/sun/security/tools/jarsigner : 
jdk/src/share/classes/sun/security/tools/jarsigner
  jdk/src/jdk.jartool/share/classes/sun/tools/jar : 
jdk/src/share/classes/sun/tools/jar
  jdk/src/jdk.jcmd/share/classes/sun/tools/jcmd : 
jdk/src/share/classes/sun/tools/jcmd
diff --git a/modules.xml b/modules.xml
--- a/modules.xml
+++ b/modules.xml
@@ -1634,6 +1645,9 @@
      <export>
        <name>com.sun.jarsigner</name>
      </export>
+    <export>
+      <name>jdk.security.jarsigner</name>
+    </export>
    </module>
    <module>
      <name>jdk.javadoc</name>

Thanks
Max