Hi Artem
In StandardCallbacks.java, you provide an array of callbacks with an
unsupported one at the end, hoping all supported ones are processed
before the last one fails. It is very natural for a LoginModule
implementation to process them one by one in their original order (like
what CustomLoginModule does) but I am not sure if this is a strict
requirement. For example, what if it tries the last one first and in
this case fails before trying all the others?
Can you find any specification on it? Or maybe in a technote article?
Another one:
- SharedState: If the callback handler is not used, does the constructor
without the argument work?
Thanks
Max
On 4/21/2015 10:22 PM, Artem Smotrakov wrote:
Hello,
Please review a couple of new tests for JAAS:
- StandardCallbacks.java is for standard JAAS callbacks (except
RealmCallback and RealmChoiceCallback since the test is not about Sasl,
and actually those two callback extends ChoiceCallback which is used in
the test)
- SharedState.java checks if a shared state is passed to login modules
Bug: https://bugs.openjdk.java.net/browse/JDK-8048138
Webrev: http://cr.openjdk.java.net/~asmotrak/8048138/webrev.00/
Artem
