This looks fine but you should wait until JDK-8078318 (Public API for jarsigner) is resolved, and then change the places where it says "{@code JarSigner}" to an "{@link JarSigner}" (using the correct package name/syntax). Add an "is blocked by" link.

Also a few other comments:

1. Add a noreg label to the bug
2. File a separate docs bug and target it to 9 to update the jarsigner man page to document that the options are deprecated. Also add a "securitydocs" label to that bug. 3. Add a "release-notes=yes" label with a few sentences describing what has been deprecated for the release notes.

--Sean

On 04/17/2015 03:03 PM, Jason Uh wrote:
Please review this change to deprecate the com.sun.jarsigner package.

webrev: http://cr.openjdk.java.net/~juh/8076535/00/
jbs: https://bugs.openjdk.java.net/browse/JDK-8076535

Thanks,
Jason

Reply via email to