Hi Joe

The changes look good.

I remember last time when Stuart updated JDK to use diamond there was a rule that if the assignment of a variable is a little far from its definition, then we don't use diamond. It seems we are not obeying it anymore?

Thanks
Max

On 4/24/2015 6:34 AM, Joseph D. Darcy wrote:
Hello,

Please review the straightforward changes to address

     JDK-8078468: Update security libraries to use diamond with
anonymous classes
     http://cr.openjdk.java.net/~darcy/8078468.0/

This patch combines two kinds of updates; the first to use traditional
diamond available since JDK 7 and the second to use diamond with
anonymous classes, a feature now available in JDK 9. As with core
libraries (JDK-8078467), many of the uses of the new feature are
locations where "new PrivilegedAction" is used.

The diamond location candidates were found using a finder built into javac.

Thanks,

-Joe

Reply via email to