webrev:http://cr.openjdk.java.net/~xuelei/8043758/webrev.latest/
Updates: 1. Update to discard invalid records, rather than use an alert message, per the requirements in section 4.1.2.7, RFC 6374. 2. Update to use a base test class, simplify the test case a lot. Thanks, Xuelei On 5/21/2015 7:34 PM, Xuelei Fan wrote: > On 5/21/2015 7:31 PM, Konstantin Shefov wrote: >> Hi Xuelei, >> >> You have the following tests: "DTLSOverDatagram.java", "Reordered.java", >> "Retransmission.java". Their code is pretty much the same despite some >> differences. >> I think it would be better to create a base test class with all common >> code and then inherit tests from that class to avoid code duplication. >> > Yes. That's also a point I want to address. If I cannot do it before > May 28, I would create a new bug to track the improvement. > > Thanks, > Xuelei > >> -Konstantin >> >> On 21.05.2015 14:19, Xuelei Fan wrote: >>> Hi, >>>>> >>>>> Please review DTLS implementation [JEP-219/JDK-8043758]: >>>>> >>>>> webrev:http://cr.openjdk.java.net/~xuelei/8043758/webrev.latest/ >>>>> JBS:https://bugs.openjdk.java.net/browse/JDK-8043758 >>>>> >>>>> I would greatly appreciate it if you could send me feedback on or >>> before >>>>> May 28, 2015. >>>>> >>>>> Thanks & Regards, >>>>> Xuelei Fan >> >
