Some nit/questions for 8031111 webrev:
In the test, why not use "noaddresses" since it's the one documented in
the krb5 conf page?
If "noaddresses" is true, then the extra_addresses has no effect, right?
I didn't see checking for the "noaddresses" in HostAddresses.java file.
Is that done somewhere else?
As for 8079821 webrev, do u need to check nt[pos-1] for overflow as well
when adding 1 to it?
Valerie
On 5/8/2015 8:00 AM, Weijun Wang wrote:
Hi Valerie
Please review the code change at
http://cr.openjdk.java.net/~weijun/8031111/webrev.00/
The codes to read local addresses are updated. We are also supporting
the extra_addresses krb5.conf setting.
This code change triggers a bug (MSOID2.java) in a test I've recently
added, please also review the change at
http://cr.openjdk.java.net/~weijun/8079821/webrev.00/
Thanks
Max
