On 06/16/2015 07:33 AM, Andrew Haley wrote:
On 06/15/2015 05:58 PM, Andrew Haley wrote:
3. I fused squaring and multiplication into a single
montgomeryMultiply method. ...
I don't agree with fusing them together. I think there should two
separate intrinsics. For one, SPARC has a montsqr and montmul
instructions. Additionally if someone wants to call montgomerySquare,
they should be able to call it directly with it's needed number of
arguments and not pass 'a' twice to satisfy an internal if().
OK, fair enough. I'll think a little more about the best way to do
this.
Done thusly. The only thing I had any doubt about was whether to use a
single flag for squaring and multiplication. This patch uses separate
flags.
http://cr.openjdk.java.net/~aph/8046943-hs-2/
http://cr.openjdk.java.net/~aph/8046943-jdk-2/
Andrew.
I'm happy with the jdk change.. thanks..
Question, on the hotspot side you said in a previous post this was
C2-only. Was there a reason you don't have it for all? Personally I'd
enable it for all unless there was a performance hit in a particular mode.
Tony
