Re: [9] RFR(M): 8076112: Add @HotSpotIntrinsicCandidate annotation to indicate methods for which Java Runtime has intrinsics

[Zoltán Majó]

Hi James,


thank you for your feedback!

I've implemented the changes you suggested, here is the updated webrev:
- top: http://cr.openjdk.java.net/~zmajo/8076112/top/webrev.07/
- jdk: http://cr.openjdk.java.net/~zmajo/8076112/jdk/webrev.07/
- hotspot: http://cr.openjdk.java.net/~zmajo/8076112/hotspot/webrev.07/

Best regards,


Zoltan


On 06/26/2015 07:23 PM, james cheng wrote:

Hi Zoltán,

I am not a reviewer.  Just saw some typos in code comments:

Here is the updated webrev:
- top: http://cr.openjdk.java.net/~zmajo/8076112/top/webrev.06/
- jdk: http://cr.openjdk.java.net/~zmajo/8076112/jdk/webrev.06/

in SHA*.java, 'implCompressImpl', "as parameter the method"

- hotspot: http://cr.openjdk.java.net/~zmajo/8076112/hotspot/webrev.06/

in vmSymbols.hpp.html,
 649 // ... e.g.,,

650&651 [ one of the closing parentheses seems superfluous]

 673 // ... approriate ...

Thanks,
-James