These new tests look fine. Thanks.
> On 1 Jul 2015, at 13:48, Bhanu Prakash Gopularam > <bhanu.prakash.gopula...@oracle.com> wrote: > > Hello, > > Please review changes for JEP 166: > Test for storing and validating the secret key entries in keystore is merged > into test/sun/security/pkcs12/StoreSecretKeyTest.java and the test > certificate files are regenerated with valid identity information. > > http://cr.openjdk.java.net/~asmotrak/bhanu/8048830/webrev.04/ > <http://cr.openjdk.java.net/%7Easmotrak/bhanu/8048830/webrev.04/> > > Thanks, > Bhanu > > From: Bhanu Prakash Gopularam > Sent: Monday, May 25, 2015 8:43 PM > To: security-dev@openjdk.java.net <mailto:security-dev@openjdk.java.net> > Subject: RFR: 8048830 - Implement tests for new functionality provided in JEP > 166 > > Hello, > > Please review tests for JEP 166: > > Tests check for default key store format i.e., PKCS 12, import a trusted cert > into PKCS 12 key store and export cert and print it. Tests validate whether > exception is thrown when key entry with invalid cert chain is imported, Read > and write key entry data to key store. Tests also validate metadata store and > load functionality. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8048830 > <https://bugs.openjdk.java.net/browse/JDK-8048830> > Webrev: http://cr.openjdk.java.net/~asmotrak/bhanu/8048830/webrev.00/ > <http://cr.openjdk.java.net/~asmotrak/bhanu/8048830/webrev.00/> > > Thanks, > Bhanu
