Hi, Max. Thanks for taking the time to review.
Regards, iris -----Original Message----- From: Weijun Wang Sent: Wednesday, July 08, 2015 8:57 PM To: Iris Clark; security-dev@openjdk.java.net Subject: Re: RFR: (s) 8130696: Security Providers need to have their version numbers updated for JDK 9 Hi Iris The change to S11N.java looks fine. Thanks Max On 07/08/2015 01:48 AM, Iris Clark wrote: > Hi. > > Please review changes to resolve the following bug: > > 8130696: Security Providers need to have their version numbers updated > for JDK 9 (Verona) > > Bug: https://bugs.openjdk.java.net/browse/JDK-8130696 > > Changeset: http://cr.openjdk.java.net/~iris/verona/8130696/webrev > > The constructor invocation for every Provider implementation contains > a hard-coded value for the version, "1.9d", which it compares to > java.specification.version. Verona [0,1] changes the system property > from "1.9" to "9". The provider's version should be changed to "9.0d". > > Many regression tests in the jdk repository fail due to this bug. > Test groups with failing tests detecting this problem include > jdk_security, jdk_management, jdk_jmx, and jdk_net. These tests now > pass. I have verified that all providers modified by 8030823 [2] have been > updated. > > After review, the changeset will be pushed to verona/stage [3]. The > changeset will go to jdk9/dev when Verona is complete later this summer. > > Thanks, > > Iris > > [0] http://openjdk.java.net/projects/verona > > [1] http://openjdk.java.net/jeps/223 > > [2] http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f1066af06fa0 > > [3] http://hg.openjdk.java.net/verona/stage >