Hi Artem
First, you shouldn't need any @modules here, the sun/security/krb5/auto
already contains a TEST.properties file covering everything. For the
same reason, you should place KinitConfPlusProps.java somewhere inside
auto. If you think a subdir is better, put it into auto/tools.
Back to the tests themselves:
I don't see how KrbTicket.java is related to the bug description. There
is no system properties mentioned.
KinitConfPlusProps.java does not seems to prove that both conf file and
system properties are used. Why should the 1st kinit call fail? Doesn't
the principal name also contain the realm here? The conf file only
contains realm and kdc and nothing else. If both conf file and system
properties are provided, how do you prove the conf file is also read and
not ignored?
Thanks
Max
On 08/05/2015 07:01 PM, Artem Smotrakov wrote:
Hello,
Please review a couple of new tests which checks if krb5 settings are
read correctly from conf file and system properties.
Bug: https://bugs.openjdk.java.net/browse/JDK-8075299
Webrev: http://cr.openjdk.java.net/~asmotrak/8075299/webrev.00/
Artem
