Great. Everything looks fine now. Thanks Max
> 在 2015年9月21日，12:54，Amanda Jiang <[email protected]> 写道： > > Hi Max, > > Thanks for reviewing this webrev. I have updated test cases by your comments > and simplify codes, please check latest webrev below and let me know if there > are any problems: > http://cr.openjdk.java.net/~amjiang/8050461/webrev.03/ > > Thanks, > Amanda > >> On 6/20/15, 7:42 AM, Weijun Wang wrote: >> Hi Amanda >> >> I'd rather see 5 JAAS conf files directly included (instead of generating >> them with codes). Then it seems you can write a single test with 5 @run >> lines. >> >> Thanks >> Max >> >>> On 6/20/2015 6:33 AM, Amanda Jiang wrote: >>> Hello, >>> >>> Please help to review following changeset, which includes new tests to >>> Verify syntax checking of java.security.auth.login.config file. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8050461 >>> Webrev: http://cr.openjdk.java.net/~amjiang/8050461/webrev.02/ >>> >>> Thanks, >>> Amanda >
