The code change looks ok. You might want to rename the test from Decomposealgorithms to DecomposeAlgorithms.
However, I am not sure if this is the ultimate solution. IMHO, it will be nice to provide several patterns, say, <hash>with<kp>in<format> etc and provide a supported list for each category (hash, kp, format). --Max > On Dec 7, 2015, at 8:35 PM, Xuelei Fan <[email protected]> wrote: > > On 12/7/2015 8:23 PM, Amy Lu wrote: >> Hi, Xuelei >> >> test/sun/security/util/AlgorithmConstraints/Decomposealgorithms.java >> >> line36 private final static String PATH = >> System.getProperty("test.src", "."); >> >> It seems that this line could be removed. >> > Oops, bad copy and past. Updated. > > Thanks, > Xuelei > >> Thanks, >> Amy >> >> On 12/7/15 7:08 PM, Xuelei Fan wrote: >>> Hi Brad, >>> >>> Please review this fix for JDK-8136410: >>> >>> http://cr.openjdk.java.net/~xuelei/8136410/webrev.00/ >>> >>> AlgorithmDecomposer cannot parse "Padding" string properly as 'in' is >>> used as a String split separator. "NoPadding" was incorrectly split as >>> "NoPadd" and "g". >>> >>> This update update the slit String split pattern, and "Padding" get >>> specially handled. >>> >>> Thanks, >>> Xuelei >> >
