Then why not fix the 2 bugs in a single changeset? --Max
> 在 2016年3月23日，17:06，Xuelei Fan <xuelei....@oracle.com> 写道： > >> On 3/23/2016 3:34 PM, Wang Weijun wrote: >> >>> On Mar 23, 2016, at 12:48 PM, Xuelei Fan <xuelei....@oracle.com> wrote: >>> >>> On 3/23/2016 12:10 PM, Wang Weijun wrote: >>>> Only 3 files touched. Are you going to make the >>>> s/BigInteger.valueOf(2)/BigInteger.TWO/ changes in other files with >>>> another bug fix? >>> There are also uses in security components. I will make the update in >>> another bug. >> >> I see. But why is ObjectIdentifier.java included in this fix? > It happens that the other bug touch those files, but > ObjectIdentifier.java is not related to that bug. > > Does it make sense? > > Thanks, > Xuelei > >> In you only keep BigInteger and BigDecimal, then I have no other comment. >> >> Thanks >> Max >> >>> >>> Thanks, >>> Xuelei >>> >>>> Thanks >>>> Max >>>> >>>>> On Mar 23, 2016, at 11:26 AM, Xuelei Fan <xuelei....@oracle.com> wrote: >>>>> >>>>> Hi, >>>>> >>>>> Please review the update for the supporting of BigInteger.TWO: >>>>> >>>>> http://cr.openjdk.java.net/~xuelei/8152237/webrev/ >>>>> >>>>> BigInteger.valueOf(2) is a common BigInteger value used in binary and >>>>> cryptography operation calculation. The BigInteger.TWO is not exported, >>>>> and hence BigInteger.valueOf(2) is used instead in applications and JDK >>>>> components. The export of static BigInteger.TWO can improve performance >>>>> and simplify existing code. >>>>> >>>>> Thanks, >>>>> Xuelei >
