Looks fine to me except two minor comments: test/java/security/testlibrary/SimpleOCSPServer.java ------------- 254 serverReady = false; For safe, I may put line 215-254 into a try-final block.
test/javax/net/ssl/Stapling/HttpsUrlConnClient.java ------------- 301 // Wait 5 seconds for server ready The comment says "5 seconds", but the actual implementation is 1 second. 5 seconds may reduce the frequency of intermittent failure. I would like to use 5 second wait and update the implementation (line 305-307). Similar to other test cases. Thanks, Xuelei On 4/12/2016 7:44 AM, Rajan Halade wrote: > Please help with your review of following patch to OCSP stapling tests. > HttpsUrlConnClient test failed intermittently with NPE because OCSP > server was not ready. With this patch, SimpleOCSPServer indicates server > ready to accept connections. Similar fix is applied to other tests in > this area. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8153829 > Webrev: http://cr.openjdk.java.net/~rhalade/8153829/webrev.00/ > > Thanks, > Rajan
