The changes in the webrev, along with the change to the module info, look good to me.
-Chris. > On 16 Apr 2016, at 01:22, Xuelei Fan <[email protected]> wrote: > > Resend. > > Looks like there jdk.crypto.pkcs11 has no dependence on jdk.unsupported > any more. Do you want to update the module-info.java in this update? > > module jdk.crypto.pkcs11 { > // Depends on SunEC provider for EC related functionality > requires jdk.crypto.ec; > - // 8153371 > - requires jdk.unsupported; > provides java.security.Provider with sun.security.pkcs11.SunPKCS11; > } > > Otherwise, looks fine to me. > > Xuelei > >> On 4/16/2016 8:13 AM, Valerie Peng wrote: >> NOTE: resend with the correct bug id. >> >> Anyone can help reviewing this? Just a one-line replacement for >> switching to the new public Thread constructor. >> No new regression test as it should be covered by the existing one. >> >> Webrev: http://cr.openjdk.java.net/~valeriep/8153371/webrev.00/ >> >> Thanks, >> Valerie >
