Thanks for your comments!
Updated webrev: http://cr.openjdk.java.net/~rhalade/8129329/webrev.01/
On 4/20/16 5:23 PM, Xuelei Fan wrote:
You made a few update of the coding style, for example line 60-62, which
is different from the traditional coding. Are you following some coding
conventions?
I use netbeans auto-format which coding conventions [1] implemented. Per
4.2, general principal is to have line break before operator.
[1]
http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-136091.html#248
As if you are already there, maybe you can do more revise.
1. although it is a test, most of the methods and fields can be private.
2. would you mind use try-with-resource for sslServerSocket, too.
These are addressed in new webrev.
Thanks,
Rajan
Thanks,
Xuelei
On 4/21/2016 5:55 AM, Rajan Halade wrote:
Please provide your review of following patch to this test to start
server in a separate thread, have additional logging and few other nits.
Old test didn't have enough logging at the time of failure so it is not
clear why client didn't connect which resulted in timeout on server accept.
Bug: https://bugs.openjdk.java.net/browse/JDK-8129329
Webrev: http://cr.openjdk.java.net/~rhalade/8129329/webrev.00/
Thanks,
Rajan
