Hello,
I would be grateful if someone could find time to review this.
I received few off-line notes and decided to rework this backport a little.
Here is my new webrev:
http://cr.openjdk.java.net/~snikandrova/8049171/webrev.01/
<http://cr.openjdk.java.net/%7Esnikandrova/8049171/webrev.01/>
List of current changes from original patch:
1) No ProcessTools.java changes in webrev as they have been backported
earlier.
2) Utils.java : new utility method transferBetweenStreams meant to be
used instead of InputStream's transferTo method that is present since 9.
3) JarUtils.java: changes in createJar method to consider a situation
then files aren't located in current directory.
4) NestedActions.java: refactored to use JarUtils method to create jars.
5) TimestampCheck.java - omitted System.getProperty("test.tool.vm.opts")
that is not used in jdk 8 testing.
6) Used System.getProperty("test.jdk") instead of
System.getProperty("java.home") in tests.
Thank you,
Svetlana
On 28.04.2016 20:35, Svetlana Nikandrova wrote:
Hello,
please review and approve the backport of tests enhancement:
Original tests from
https://bugs.openjdk.java.net/browse/JDK-8049171
jdk 9 review:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-January/031006.html
jdk 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/5c61ccd9c162
Originally reviewed by Max Wang
Webrev:
http://cr.openjdk.java.net/~snikandrova/8049171/webrev.00/
<http://cr.openjdk.java.net/%7Esnikandrova/8049171/webrev.00/>
List of changes between original patch and current webrev:
1) No ProcessTools.java changes as they have been backported earlier.
2) JarUtils.java : private method transferToOutputStream instead
ofInputStream's transferTo method (present since 9).
3) TimestampCheck.java - changes applied by hand to omit
System.getProperty("test.tool.vm.opts") that is not used in jdk 8 testing
4) Used System.getProperty("test.jdk") instead of
System.getProperty("java.home")
Tested with JPRT.
Thank you,
Svetlana
