On 5/10/2016 12:16 AM, Michael StJohns wrote:
> You're going to hate me, but shouldn't this be checking the Provider
> rather than the OS when trying to determine which test to ignore?
>
It's more accurate to check the provider, too.
- if (!System.getProperty("os.name").equals("SunOS")) {
+ if (provider.getName().equals("SunPKCS11-Solaris") &&
+ !System.getProperty("os.name").equals("SunOS")) {
One of the purpose of code review is asking for suggestions or even
objections. I appreciate you feedback very much!
Thanks,
Xuelei
> Mike
>
>
> On 5/9/2016 10:36 AM, Xuelei Fan wrote:
>> Updated to ignore the test on Solaris only:
>>
>> http://cr.openjdk.java.net/~xuelei/8154344/webrev.01/
>>
>> Thanks,
>> Xuelei
>>
>> On 5/8/2016 7:59 AM, Xuelei Fan wrote:
>>> I still want the rest part (public key checking) get executed and
>>> noticed. I will keep track of the evaluation of the underlying platform
>>> crypto lib.
>>>
>>> Thanks,
>>> Xuelei
>>>
>>> On 5/7/2016 11:31 AM, Wang Weijun wrote:
>>>> Or can we put it into problem list for Solaris now?
>>>>
>>>>> 在 2016年5月7日，07:19，Xuelei Fan <xuelei....@oracle.com> 写道：
>>>>>
>>>>> Yes. This is might be a platform crypto lib issue. I want to bring
>>>>> back the testing at first, and open the test again after the issue get
>>>>> fixed.
>
>
