I meant coding style. --Max
> On May 21, 2016, at 2:11 PM, Anthony Scarpino <anthony.scarp...@oracle.com> > wrote: > > If breaks were not allowed, I would hope the compiler and/or tests would have > failed. > > Tony > > On 05/20/2016 10:11 PM, Wang Weijun wrote: >> I am not sure if it's good to break inside a type name. I grep through JDK >> and seems nowhere else is doing it. >> >> --Max >> >>> On May 20, 2016, at 11:42 PM, Svetlana Nikandrova >>> <svetlana.nikandr...@oracle.com> wrote: >>> >>> Glad to hear it. Thank you! >>> >>> Svetlana >>> >>> On 20.05.2016 17:24, Anthony Scarpino wrote: >>>> On 05/20/2016 07:13 AM, Svetlana Nikandrova wrote: >>>>> Hello, >>>>> >>>>> please review this code format fix for Provider.java. No code changes, >>>>> just a few breaks in a really long (like > 120 characters) lines. Also >>>>> examined other classes in**the java.security package, but seems like >>>>> Provider.java is the only one affected. >>>>> >>>>> http://cr.openjdk.java.net/~snikandrova/8155575/webrev.00/ >>>>> <http://cr.openjdk.java.net/%7Esnikandrova/8155575/webrev.00/> >>>>> >>>>> Thank you, >>>>> Svetlana >>>> >>>> >>>> Your changes look fine.. >>>> >>>> Tony >>>> >>> >> >
