Thanks for the patch, Siba!
This fix looks confusing to me. TestDSAGenParameterSpec has timeout
specified for 2048 but not for 3072/224 and 4096 case. Why would these
run faster than smaller lengths?
May be there is some other reason, area experts can help here.
Thanks,
Rajan
On 5/31/2016 08:04, Sibabrata Sahoo wrote:
Hi,
Please review the fix for the following JBS bugs,
JBS: https://bugs.openjdk.java.net/browse/JDK-8157896
https://bugs.openjdk.java.net/browse/JDK-8157898
webrev: http://cr.openjdk.java.net/~ssahoo/8157896/webrev.00/
<http://cr.openjdk.java.net/%7Essahoo/8157896/webrev.00/>
Description:
These Tests takes a lots of time to generate DSA parameter when the
prime and subprime values are greater in some machine with some
platform. The reason is being the operations are CPU intensive, which
causes the Tests to timeout in rare occasion. But the Test performance
can be improved by, instead of generating DSA parameter with all
supported input in a single run, it can be divided for each input as a
separate run, so that each run can complete much before compared to
all input at once. It also provides the flexibility to associate test
options like “timeout” for specific input type where the execution
time is expected to exceed the default.
Note: The fix won’t give a guarantee that the timeout will never
happen but it can surely help reduce the timeout in greater extent.
Please provide your suggestion, in case any.
Thanks,
Siba
