> On Jun 9, 2016, at 3:22 PM, Valerie Peng <valerie.p...@oracle.com> wrote: > > > Anyone can help reviewing this one-line change which removes a redundant > declaration? > > As Apple provider is instantiated directly (see > sun.security.jca.ProviderConfig.java) and not loaded through ServiceLoader , > we can safely remove the line for ServiceLoader lookup. No new regression > test as this is just a minor performance fix. > > Webrev: http://cr.openjdk.java.net/~valeriep/8157489/
So all builtin security providers in java.base will not be found from ServiceLoader.load(Provider.class). test/java/security/Provider/DefaultProviderList.java should then be updated to expect all providers are not from java.base and check Class::getModule(). Currently the test simply skips some builtin security providers. Mandy
