Hello, While you are at that code, can the JavaDoc @code classnames be changed into @link as well? (Not sure if it works for packages).
Gruss Bernd -- http://bernd.eckenfels.net -----Original Message----- From: Sean Mullan <sean.mul...@oracle.com> To: Vincent Ryan <vincent.x.r...@oracle.com>, OpenJDK <security-dev@openjdk.java.net> Sent: Fr., 17 Juni 2016 16:41 Subject: Re: RFR 8157730: Mark deprecated java.security.{Identity, IdentityScope, Signer} APIs with forRemoval=true Looks fine to me. --Sean On 06/17/2016 08:52 AM, Vincent Ryan wrote: > Three Identity-related classes were deprecated in JDK 1.2. > Please review the patch below that marks them as candidates for removal > in a future JDK release. > > See http://openjdk.java.net/jeps/277 for details of the enhanced > deprecation annotation. > > Thanks. > > > diff --git a/src/java.base/share/classes/java/security/Identity.java > b/src/java.base/share/classes/java/security/Identity.java > --- a/src/java.base/share/classes/java/security/Identity.java > +++ b/src/java.base/share/classes/java/security/Identity.java > @@ -55,8 +55,9 @@ > * replaced by {@code java.security.KeyStore}, the > * {@code java.security.cert} package, and > * {@code java.security.Principal}. > + * This class is subject to removal in a future version of Java SE. > */ > -@Deprecated > +@Deprecated(since="1.2", forRemoval=true) > public abstract class Identity implements Principal, Serializable { > > /** use serialVersionUID from JDK 1.1.x for interoperability */ > > > diff --git > a/src/java.base/share/classes/java/security/IdentityScope.java > b/src/java.base/share/classes/java/security/IdentityScope.java > --- a/src/java.base/share/classes/java/security/IdentityScope.java > +++ b/src/java.base/share/classes/java/security/IdentityScope.java > @@ -60,8 +60,12 @@ > * replaced by {@code java.security.KeyStore}, the > * {@code java.security.cert} package, and > * {@code java.security.Principal}. > + * This class is subject to removal in a future version of Java SE. > + * > + * Note that the security property {@code policy.ignoreIdentityScope} > + * is only applicable to these APIs and is also a candidate for removal. > */ > -@Deprecated > +@Deprecated(since="1.2", forRemoval=true) > public abstract > class IdentityScope extends Identity { > > > diff --git a/src/java.base/share/classes/java/security/Signer.java > b/src/java.base/share/classes/java/security/Signer.java > --- a/src/java.base/share/classes/java/security/Signer.java > +++ b/src/java.base/share/classes/java/security/Signer.java > @@ -43,8 +43,9 @@ > * replaced by {@code java.security.KeyStore}, the > * {@code java.security.cert} package, and > * {@code java.security.Principal}. > + * This class is subject to removal in a future version of Java SE. > */ > -@Deprecated > +@Deprecated(since="1.2", forRemoval=true) > public abstract class Signer extends Identity { > > private static final long serialVersionUID = -1763464102261361480L; >