On 07/01/2016 09:38 AM, John Jiang wrote:
Ping again ;-)

Looks good. My only comment is that SocksProxy.java might be generally useful for other tests, so it may make sense later on to move it to jdk/test/java/security/testlibrary, but no action is needed right now.

--Sean


John Jiang


On 2016/6/28 6:42, John Jiang wrote:
Please review this patch.
Thanks!

John Jiang


On 2016/6/24 16:55, John Jiang wrote:
Hi,
Due to JDK-8134577, the test
sun/security/x509/URICertStore/ExtensionsWithLDAP.java cannot resolve
hosts from a local name service provider.
This fix creates a simple Socks4 proxy, and use it to resolve hosts
from Socket.

Issue: https://bugs.openjdk.java.net/browse/JDK-8157667
Webrev: http://cr.openjdk.java.net/~jjiang/8157667/webrev.01

Please note that, this fix provides two separated local hosts files.
Each of them contains only one host entry.
And the test is executed twice in deed. Each time, the test focus
only one specific host, and uses one hosts file accordingly.
If one hosts file includes two entries, like the below,
127.0.0.1 ldap.host.for.crldp
127.0.0.1 ldap.host.for.aia
then, only the first host, ldap.host.for.crldp, is resolved by the
proxy.
If I misunderstand something, or you have better solution, please let
me know.

Thanks!

John Jiang





Reply via email to