That fix looks fine. Is there any significant performance impact due to calling CryptAcquireCertificatePrivateKey twice? Thanks.
> On 16 Aug 2016, at 13:56, Ivan Gerasimov <ivan.gerasi...@oracle.com> wrote: > > A gentle reminder. > > Would you please help review at your convenience. > > With kind regards, > Ivan > > > On 09.08.2016 12:27, Ivan Gerasimov wrote: >> Hello! >> >> In order to reduce the number of popup dialog windows during accessing the >> smartcard, it is proposed to first do a silent "probe" step. >> Only if this probe succeeded, or if it failed due to that SILENT flag, we'll >> try to re-acquire the key normally (i.e. not silently). >> >> Would you please help review this proposal? >> >> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8153438 >> WEBREV: http://cr.openjdk.java.net/~igerasim/8153438/00/webrev/ >> >> With kind regards, >> Ivan >> >> >
