Thank you Sean and David. Regards, Ramanand.
-----Original Message----- From: david buck Sent: Thursday, August 18, 2016 1:26 PM To: Seán Coffey; Ramanand Patil Cc: jdk8u-dev; security-dev@openjdk.java.net Subject: Re: [8u-dev] Request for Approval: Backport of 8144566: Custom HostnameVerifier disables SNI extension approved for push to 8u-dev Cheers, -Buck On 2016/08/18 16:51, Seán Coffey wrote: > Changes look good Ramanand. Reviewed. > > Regards, > Sean. > > On 18/08/2016 07:03, David Buck wrote: >> Hi Ramanand! >> >> As there are (minor) changes between the two change sets, you will >> need to get a code review of the backported changes. I have included >> the security-dev alias in the CC list. >> >> Cheers, >> -Buck >> >>> On Aug 18, 2016, at 14:34, Ramanand Patil >>> <ramanand.pa...@oracle.com> >>> wrote: >>> >>> Hi, >>> >>> Please review and approve the backport of 8144566 to 8u-dev. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8144566 >>> >>> JDK9 Changeset: >>> http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/1781aba4f7e3 >>> >>> JDK9 Review Thread: >>> http://mail.openjdk.java.net/pipermail/security-dev/2015-December/01 >>> 3171.html >>> >>> >>> JDK8u-dev Webrev: >>> http://cr.openjdk.java.net/~rpatil/8144566/webrev.00/ >>> >>> Changes apply semi-cleanly to jdk8u-dev after path reshuffling. >>> Below are few reasons for manual edits in the jdk8u-dev patch: >>> >>> 1. JDK9 class name for "JavaNetAccess" is changed to " >>> JavaNetInetAddressAccess". >>> 2. test/javax/net/ssl/ServerName/BestEffortOnLazyConnected.java >>> pathToStores(keystore path) doesn't exist in JDK8u, hence changed >>> the variable to point to available path. >>> 3. >>> test/sun/net/www/protocol/https/HttpsURLConnection/ImpactOnSNI.java >>> pathToStores(keystore path) doesn't exist in JDK8u, hence changed >>> the variable to point to available path. >>> >>> >>> Regards, >>> Ramanand. >
