Hi Siba,

I see that the test expects only true or false. You can just pass these boolean values, and check() can make sure that everything returns the expected boolean value without building a string. That would be clearer to me. Not an issue, it's up to you to change it or not.

Artem


On 09/13/2016 03:14 AM, Sibabrata Sahoo wrote:

Hi,

Please review the patch for,

JBS: https://bugs.openjdk.java.net/browse/JDK-8156054

Webrev: http://cr.openjdk.java.net/~ssahoo/8156054/webrev.00/ <http://cr.openjdk.java.net/%7Essahoo/8156054/webrev.00/>

Description:

It checks equals(), implies() and hashCode () of FilePermission when “jdk.io.permissionsUseCanonicalPath” set and un-set. Along with, it also verify compatibility with previous JDK version.

Thanks,

Siba


Reply via email to