OK. Looks fine to me.
Thanks,
Xuelei
On 9/14/2016 9:58 PM, Sergei Kovalev wrote:
Hi Xuelei,
I discovered 53 tests in javax/net/ssl folder that refer to
/sun/security/krb5/auto. In general it is about 10 unique tests. All the
tests depends on KDC class. In other places the tests repeated with
different set of environment variable. e.g.
"-Dtest.security.protocol=TLSv1.1", etc.
So I cannot remove reference to the library.
14.09.16 15:54, Xuelei Fan wrote:
Hi Sergei,
Thanks for the update. The fix looks fine to me. However, I'm not
sure why some tests need the "/sun/security/krb5/auto" libraries and
the related modules. As you were already there, would you mind help
to test whether the "/sun/security/krb5/auto" library can be removed
for some tests?
Thanks,
Xuelei
On 9/14/2016 8:22 PM, Sergei Kovalev wrote:
Hello Team,
Could you please review below fix for
Bug ID: https://bugs.openjdk.java.net/browse/JDK-8166032
Code review: http://cr.openjdk.java.net/~skovalev/8166032/webrev.00/
Issue: The test should be able to pass or skipped by JTreg test suite if
required modules have not been included in custom JRE.
Solution: added '@modules' tags and appropriate module list to tests
header.
Testing done locally using JTregt test suite.
