Hi Xuelei,
Sure, I am fine to use the approach which is implemented in
SSLSocketSample.java. But please note that
SSLEngineBadBufferArrayAccess.java test uses ServerSocket+SSEngine on
server side, so I applied the approach from SSLSocketSample.java to the
test:
http://cr.openjdk.java.net/~asmotrak/8163924/webrev.01/
If everything is okay, I am going to apply this approach to other test
bugs we have.
I am wondering if we could move some common code from
SSLSocketSample.java to a helper class, so that it could be re-used by
other tests (not for all of them because tests may be different). It
might reduce some duplicate code.
Artem
On 09/13/2016 06:39 PM, Xuelei Fan wrote:
I think the failure may caused by using free port by other test cases.
As you were already there, would you mind update to use the
SSLSocketSample.java template under the folder
test/javax/net/ssl/templates?
Thanks,
Xuelei
On 9/14/2016 9:31 AM, Artem Smotrakov wrote:
Hello,
Not urgent, but I would appreciate if somebody can take a look at the
webrev below and webvev for 8164591. Thank you!
Artem
On 09/07/2016 02:58 PM, Artem Smotrakov wrote:
Hello,
Please review the following patch for
SSLEngineBadBufferArrayAccess.java test.
The test has been observed to fail intermittently with "Unrecognized
SSL message" error. I couldn't reproduce it, and it's currently not
clear what caused the test to fail. One guess is that something else
might connect to the server which caused this error. The patch enables
additional debug output, so that we have more info if it fails next
time. JTREG truncates logs, but it's fine since we are interested only
in last handshaking.
The patch also updates the test to report unexpected exceptions, and
close files and sockets.
Any other suggestions are very welcome.
Bug: https://bugs.openjdk.java.net/browse/JDK-8163924
Webrev: http://cr.openjdk.java.net/~asmotrak/8163924/webrev.00/
Artem
