Change looks fine. One question: When you say the --limit-modules option, is it a new option for jtreg that allows it to automatically choose modules described in the @modules tags? Or it's just the standard VM option and you still need to provide the module names yourself?
Advertising
Thanks Max > On Sep 21, 2016, at 8:08 PM, Sergei Kovalev <sergei.kova...@oracle.com> wrote: > > Hello team, > > Could you please review small fix for regression tests related to smartcardio > API? > > BugID: https://bugs.openjdk.java.net/browse/JDK-8166450 > WebRev: http://cr.openjdk.java.net/~skovalev/8166450/webrev.00/ > > Issue: unable to run smartcardio related tests bu jtreg by default. > Root cause: missed module declaration in the tests header. > Solution: Adding missed module declaration. > Testing done: Fix tested locally using jtreg and "--limit-modules" command > line option. > > -- > With best regards, > Sergei >
