> On Nov 3, 2016, at 8:27 AM, Artem Smotrakov <artem.smotra...@oracle.com> > wrote: > > Hi Max, > > Please see inline. > > > On 11/01/2016 11:59 PM, Wang Weijun wrote: >> Main.java: >> >> The warning (and the subsequent empty line) should be printed into >> System.err.
This one? > > Thank you for review Max, please take a look at updated webrev: > > http://cr.openjdk.java.net/~asmotrak/8168882/webrev.01/ Fine except for the System.out one above. > > By the way, I just noticed that we have another version of JarUtils.java > which was added by Alan 7 month ago > > http://hg.openjdk.java.net/jdk9/dev/jdk/log/1396fb6d0279/test/lib/testlibrary/JarUtils.java Looks like it's only used by himself, and has 2 lines of history. Also, my understanding is that we are switching to test utils in the root repo. A lot of same name utils in jdk/test were deprecated. Thanks Max > > Artem