Looks good, but don't forget to add a noreg-self label to the bug.
--Sean
On 12/4/16 9:29 PM, John Jiang wrote:
Hi Sean,
Thanks for your comments.
Please take a look at the new wevrev:
http://cr.openjdk.java.net/~jjiang/8170523/webrev.01/
Best regards,
John Jiang
On 2016/12/3 5:02, Sean Mullan wrote:
Hi John,
I don't think we should modify the test to disable a SecurityManager
and then reenable it to avoid a security check -- that seems like a
pattern we should avoid. Have you tried to reorganize this code so
that this setup is done before you initially enable the SecurityManager?
Thanks,
Sean
On 12/1/16 10:32 PM, John Jiang wrote:
Hi,
Some PKCS11 tests call PKCS11Test.getDistro(), which run command "uname
-v", to determine the OS distro.
But if the tests enable security manager and don't grant appropriate
file permission, PKCS11Test.getDistro() fails to get the distro.
Then, the associated cases will be ignored since the tests think that
the OS is not the target.
Webrev: http://cr.openjdk.java.net/~jjiang/8170523/webrev.00/
Issue: https://bugs.openjdk.java.net/browse/JDK-8170523
Best regards,
John Jiang
