Hi, +1 (I am not really an expert on jar signing but the basic test looks fine).
Some minor comments below, no need for another review.
Paul.
113 Stream.of(sourceFiles).map(Object::toString).forEach(x ->
launcher.addToolArg(x));
119 Stream.of(args).forEach(x -> launcher.addToolArg(x));
If you like you can do:
launcher::addToolArg
148 private static OutputAnalyzer verify (String signedJarName) throws
Throwable {
Rogue ‘ ‘ between the method name and it’s parameter list.
> On 12 Dec 2016, at 14:43, Amanda Jiang <amanda.ji...@oracle.com> wrote:
>
> Hi All,
>
> Please help to review following changeset, which tests that jarsigner tool
> works with multi-release JAR files.
>
> Webrev: http://cr.openjdk.java.net/~amjiang/8075618/webrev.01/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8075618
>
>
> Thanks,
> Amanda
signature.asc
Description: Message signed with OpenPGP using GPGMail
