On 01/19/2017 11:50 AM, Mandy Chung wrote:
On Jan 19, 2017, at 11:39 AM, Anthony Scarpino <anthony.scarp...@oracle.com>
wrote:
Hi,
I need a review to rename the jdk.crypto.token to jdk.crypto.cryptoki. This is to change
what 8171202 had done to the original jdk.crypto.pkcs11 module. For those not familiar
with discussions elsewhere, the term "token" is confusing and unclear as it can
mean many things cryptographically. The use of cryptoki is more accurate to the original
'pkcs11' name and still conforming to the new naming standard.
http://cr.openjdk.java.net/~ascarpino/8172527/webrev-root/
http://cr.openjdk.java.net/~ascarpino/8172527/webrev-jdk/
The webrev shows deleted/new files for src/jdk.crypto.token source files rather
than rename. Did you use hg rename?
Changes in other files looks good.
Mandy
Good catch.. that'll teach me for trusting the graphical tool to rename
a directory when I used 'Rename'.
Also I found Brad's issue as it was a new changeset that just showed up
in that file.
I updated the webrev, which looks better now:
http://cr.openjdk.java.net/~ascarpino/8172527/webrev-jdk.01/
Tony
