Hi Jamil

Many thanks to the review. How do you think of the other two in my
follow up mails?

https://bugs.openjdk.java.net/browse/JDK-8173035
(https://bugs.openjdk.java.net/browse/JDK-8029904) Remove
com.sun.security.auth.callback.DialogCallbackHandler

`com.sun.security.auth.callback.DialogCallbackHandler` has been
removed in JDK 9. This class, in the JDK-specific extensions to JAAS,
was deprecated in JDK 8 and previously flagged for removal.

https://bugs.openjdk.java.net/browse/JDK-8173018
(https://bugs.openjdk.java.net/browse/JDK-8076535) Deprecate the
com.sun.jarsigner package

The `com.sun.jarsigner` package is being deprecated. This includes
the `ContentSigner` class, the `ContentSignerParameters` interface,
and the jarsigner command's "-altsigner" and "-altsignerpath"
options.


Thanks
Max


On 01/20/2017 06:26 AM, Jamil Nimeh wrote:
Hi Max, just one nit for JDK-8044085:

The release note is one sentence, but it is a bit of a run-on. It
might be worth breaking it up into two sentences, the first for the
description and the second containing the example.

Aside from that they look good to me.

Reply via email to