Hi Siba,

In valid.policy, use 'grant codeBase "file:${test.classes}/*"' so that only the tests are granted the needed permissions.

In ClassLoaderTest.java, the @bug should be 8168075. Also, the @summary contains a bunch of lines (29-39) that should probably just be code comments.

Seems fine otherwise.

--Sean


On 1/11/17 10:33 AM, Sibabrata Sahoo wrote:
Hi Adam/Sean,



This patch is waiting for your review.



Thanks,

Siba



*From:*Sibabrata Sahoo
*Sent:* Friday, December 02, 2016 6:56 PM
*To:* Sean Mullan; security-dev@openjdk.java.net
*Subject:* [9] RFR: 8168423: Test Task: Custom system class loader +
security manager + malformed policy file = recursive initialization



Hi,



Please review the patch for,



JBS: https://bugs.openjdk.java.net/browse/JDK-8168423

Webrev: http://cr.openjdk.java.net/~ssahoo/8168423/webrev.00/



Description:

This webrev address all possible cases for Classloader with
SecurityManager having combination of valid/malformed policy file. This
Test is going to fail until JDK-8168075 get fixed. In the mean time, it
can be used to verify the fix for JDK-8168075.



Here is the generic Logic behind generating all possible Test cases with
different combination of policy file, class loader and module types.

for(policyFile : {"NO_POLICY", "VALID", "MALFORMED"}) {

    for(classLoader : {"SystemClassLoader", "CustomClassLoader"}){

       // It uses possible set of regular/modular jars to generate all
possible Test cases in –cp and –module-path.

        for(clientModuletype : {"STRICT", "AUTO", "UNKNOWN"}) {

            for(classLoaderModuleType : {"STRICT", "AUTO", "UNKNOWN"}) {

                 Create and run java command line for each possible Test
cases and verify result.

            }

        }

    }

}



Thanks,

Siba



Reply via email to